Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter mod list #1179

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Filter mod list #1179

merged 2 commits into from
Jan 24, 2024

Conversation

anttimaki
Copy link
Collaborator

No description provided.

@anttimaki
Remove unnecessary intermediate function
bf6f1b8
@anttimaki
Skip filtering if search query is empty
3933ba6 
I assume the reason for the if-block is to return early if the list
doesn't need filtering. It has never behaved this way, though.
@ebkr
Copy link
Owner

ebkr commented Jan 23, 2024

Does this have any impact if you:

  1. download a mod
  2. close out of the modal
  3. go to the installed screen before the install has completed

Assuming the list refreshes then there's no issue, just one to watch out for

@anttimaki
Copy link
Collaborator Author

Does this have any impact if you:

1. download a mod

2. close out of the modal

3. go to the installed screen before the install has completed

Assuming the list refreshes then there's no issue, just one to watch out for

Tested now and yes, the list refreshes fine.

@anttimaki anttimaki merged commit 537fa64 into develop Jan 24, 2024
3 checks passed
@anttimaki anttimaki deleted the filter-mod-list branch January 24, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebkr ebkr ebkr approved these changes

@MythicManiac MythicManiac Awaiting requested review from MythicManiac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anttimaki @ebkr