Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add i18n support; add Chinese language; add settings to change the language. #1332

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

lolligoo
Copy link

#454 #1169 #273

The translation may not be very good.

before:

b
bs

after:

a
as

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

@lostone-zc
Copy link

你好像把 configprofile 都翻译成 配置 了。这两个词还是有区别的,翻译成同一个中文词感觉不太合适。根据 profile作用来看,profile 更偏向于目录、索引一类的东西

@lolligoo
Copy link
Author

你好像把 configprofile 都翻译成 配置 了。这两个词还是有区别的,翻译成同一个中文词感觉不太合适。根据 profile作用来看,profile 更偏向于目录、索引一类的东西

有些地方翻译的确实有问题,profile 翻译成档案怎么样?

@lostone-zc
Copy link

翻译成档案感觉可以

@TianMengLucky
Copy link

你好像把 configprofile 都翻译成 配置 了。这两个词还是有区别的,翻译成同一个中文词感觉不太合适。根据 profile作用来看,profile 更偏向于目录、索引一类的东西

有些地方翻译的确实有问题,profile 翻译成档案怎么样?

“profile” 翻译成“资料”或者“档案”确实比较好
“最后更新”要不改成“最新更新”吧
“启动模组化”把那个“化”去掉吧

fix some issus that display language will be undefiend;
@lostone-zc
Copy link

Do you support search games' Chinese name?

Not a recommended action, but it seems like adding Chinese name to src/model/game/GameManager.ts can solve it.
For example for this line:
change ["DSP"] to ["DSP", "戴森球计划"]
Although I don't think it's designed to do that, but it should work I think.

@TianMengLucky
Copy link

Do you support search games' Chinese name?你们支持搜索游戏的中文名称吗?

Not a recommended action, but it seems like adding Chinese name to src/model/game/GameManager.ts can solve it.不是一个推荐的操作,但似乎添加中文名称 src/model/game/GameManager.ts 可以解决它。 For example for this line:例如,对于这一行: change ["DSP"] to ["DSP", "戴森球计划"]更改 ["DSP"]["DSP", "戴森球计划"] Although I don't think it's designed to do that, but it should work I think.虽然我不认为它是为了做到这一点而设计的,但我认为它应该有效。

你还是另外创建一个PR来增加搜索别名吧

@lostone-zc
Copy link

你还是另外创建一个PR来增加搜索别名吧

现在好没到那一步呢。而且具体方法也有待讨论,那么做方法虽然简单,但是别名那里会越来越长的

@TianMengLucky
Copy link

现在似乎冲突了

@TianMengLucky TianMengLucky mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants