Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "enter profile code" phase of profile import modal #1624

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

anttimaki
Copy link
Collaborator

  • Remove the somewhat unnecessary "You haven't entered a code" and "You may import the profile" badges that mostly just look awkward
  • Show "Invalid code" badge only if a profile code has been entered
  • Remove the big red button when a valid profile code hasn't been entered. This looked like an error state before user has entered the code. Just disabling the Continue button if the code is invalid seems sufficient
  • Combine the two remaining buttons into one
  • Prevent submitting the form when the download is already in progress, both via button and key press
  • Move isProfileCodeValid helper to modal components as that's the only place where it's used. Remove the unnecessary argument to make the method a computed value

- Remove the somewhat unnecessary "You haven't entered a code" and "You
  may import the profile" badges that mostly just look awkward
- Show "Invalid code" badge only if a profile code has been entered
- Remove the big red button when a valid profile code hasn't been
  entered. This looked like an error state before user has entered the
  code. Just disabling the Continue button if the code is invalid seems
  sufficient
- Combine the two remaining buttons into one
- Prevent submitting the form when the download is already in progress,
  both via button and key press
- Move isProfileCodeValid helper to modal components as that's the only
  place where it's used. Remove the unnecessary argument to make the
  method a computed value
@anttimaki anttimaki force-pushed the import-code-improvements branch from b33feb0 to cbbf040 Compare January 27, 2025 10:52
@anttimaki anttimaki merged commit fa7faed into develop Jan 27, 2025
5 checks passed
@anttimaki anttimaki deleted the import-code-improvements branch January 27, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant