Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent doing mod list refresh while there are active mod downloads #1642

Closed

Conversation

VilppeRiskidev
Copy link
Collaborator

No description provided.

@VilppeRiskidev VilppeRiskidev self-assigned this Feb 24, 2025
@VilppeRiskidev
Copy link
Collaborator Author

I might do some more testing locally, I'm 85% confident in these changes.

Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If user visits the SettingsView of ProfileImportModal (and asumably ModListUpdateBanner which I did't test), they look like user could start the mod list refresh, but clicking them does nothing and gives no feedback of any sort. I would suggest we add "if active downloads" check to those UI components and tell the user to wait until the mod downloads finishes.

This is somewhat minor thing, but I think it should be rather easy to address.

@VilppeRiskidev VilppeRiskidev force-pushed the prevent-update-when-downloading branch from 146c7ee to 5d0995b Compare February 26, 2025 19:51
@VilppeRiskidev
Copy link
Collaborator Author

If user visits the SettingsView of ProfileImportModal (and asumably ModListUpdateBanner which I did't test), they look like user could start the mod list refresh, but clicking them does nothing and gives no feedback of any sort. I would suggest we add "if active downloads" check to those UI components and tell the user to wait until the mod downloads finishes.

This is somewhat minor thing, but I think it should be rather easy to address.

Created a PR for this: #1646

@anttimaki
Copy link
Collaborator

Created a PR for this: #1646

IIRC we discussed recently that fixing issues in one PR in another PR don't always make sense, since it just increases the number of open PRs if the first one can't be merged before the second one is ready to merged. I'd say this is one of those cases, as merging these changes without the other UI changes would result in an awkward version of the manager.

You could perhaps use git's cherry-pick to include the commit from #1646 in this one and close #1646. Or close this one and make #1646, including this commit, point to #1633.

@VilppeRiskidev
Copy link
Collaborator Author

Created a PR for this: #1646

IIRC we discussed recently that fixing issues in one PR in another PR don't always make sense, since it just increases the number of open PRs if the first one can't be merged before the second one is ready to merged. I'd say this is one of those cases, as merging these changes without the other UI changes would result in an awkward version of the manager.

You could perhaps use git's cherry-pick to include the commit from #1646 in this one and close #1646. Or close this one and make #1646, including this commit, point to #1633.

Did the second option so I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants