Skip to content

feat(admin): Implement schedule page under Admin tab #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sameed20
Copy link

This PR introduces the Schedule Page under the Admin tab.

@sameed20 sameed20 added enhancement New feature or request needs code review needs codes review needs general test needs general test labels Feb 12, 2025
@sameed20 sameed20 force-pushed the feat/admin-schedule-page branch from dcbfc15 to 55f3a8b Compare February 28, 2025 05:01
@sameed20
Copy link
Author

Hi @amritkv I have addressed the above changes that were asked. Please review it again.

@amritkv
Copy link
Contributor

amritkv commented Mar 4, 2025

Hi @amritkv I have addressed the above changes that were asked. Please review it again.

Hey @sameed20 ! Few of the translations are not appearing and even headings are not coming up for few languages as shown below.

image

import ScheduleList from './components/ScheduleList'

export const metadata: Metadata = {
title: 'Admin - Schedule',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sameed20 Please add translation to this page title as well.

onClick={handleCancelAllTasks}
disabled={status !== 'authenticated'}
>
{t('Cancel all Schedule Tasks')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sameed20 Please check the spellings with existing stage/prod deployments

scheduleUrl="schedule/cveService"
cancelUrl="schedule/unscheduleCve"
scheduleLabel={t('Schedule CVE Service')}
cancelLabel={t('Cancel CVE Service')}
Copy link
Contributor

@amritkv amritkv Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sameed20 Please check the button enable/disable states for all the buttons

</h5>
<ScheduleItem
scheduleUrl="schedule/scheduleSvmSync"
cancelUrl="schedule/unscheduleSvmSync"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sameed20 ! This unscheduleSvmSync seems to be a DELETE request. Please check.

</h5>
<ScheduleItem
scheduleUrl="schedule/svmReverseMatch"
cancelUrl="schedule/unscheduleSvmReverseMatch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sameed20 ! This unscheduleSvmReverseMatch seems to be a DELETE request. Please check.

</h5>
<ScheduleItem
scheduleUrl="schedule/monitoringListUpdate"
cancelUrl="schedule/cancelMonitoringListUpdate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sameed20 ! This cancelMonitoringListUpdate seems to be a DELETE request. Please check.

@heliocastro
Copy link
Contributor

@sameed20 Are you planning to solve @amritkv issues and fix the conflicts ?

@sameed20
Copy link
Author

@sameed20 Are you planning to solve @amritkv issues and fix the conflicts ?

@heliocastro Yes

@sameed20 sameed20 added WIP and removed enhancement New feature or request labels Mar 19, 2025
@sameed20 sameed20 force-pushed the feat/admin-schedule-page branch from 55f3a8b to b27cfff Compare April 3, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review needs codes review needs general test needs general test WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants