-
Notifications
You must be signed in to change notification settings - Fork 45
feat(admin): Implement schedule page under Admin tab #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(admin): Implement schedule page under Admin tab #485
Conversation
dcbfc15
to
55f3a8b
Compare
Hi @amritkv I have addressed the above changes that were asked. Please review it again. |
import ScheduleList from './components/ScheduleList' | ||
|
||
export const metadata: Metadata = { | ||
title: 'Admin - Schedule', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sameed20 Please add translation to this page title as well.
onClick={handleCancelAllTasks} | ||
disabled={status !== 'authenticated'} | ||
> | ||
{t('Cancel all Schedule Tasks')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sameed20 Please check the spellings with existing stage/prod deployments
scheduleUrl="schedule/cveService" | ||
cancelUrl="schedule/unscheduleCve" | ||
scheduleLabel={t('Schedule CVE Service')} | ||
cancelLabel={t('Cancel CVE Service')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sameed20 Please check the button enable/disable states for all the buttons
</h5> | ||
<ScheduleItem | ||
scheduleUrl="schedule/scheduleSvmSync" | ||
cancelUrl="schedule/unscheduleSvmSync" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sameed20 ! This unscheduleSvmSync
seems to be a DELETE
request. Please check.
</h5> | ||
<ScheduleItem | ||
scheduleUrl="schedule/svmReverseMatch" | ||
cancelUrl="schedule/unscheduleSvmReverseMatch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sameed20 ! This unscheduleSvmReverseMatch
seems to be a DELETE
request. Please check.
</h5> | ||
<ScheduleItem | ||
scheduleUrl="schedule/monitoringListUpdate" | ||
cancelUrl="schedule/cancelMonitoringListUpdate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sameed20 ! This cancelMonitoringListUpdate
seems to be a DELETE
request. Please check.
@heliocastro Yes |
55f3a8b
to
b27cfff
Compare
b27cfff
to
8316e0f
Compare
This PR introduces the Schedule Page under the Admin tab.