Skip to content

fix(build): TypeScript build failure in TableLicense and Table components' RefObject definition #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

harshitg927
Copy link

Description

This PR fixes a build failure caused by a TypeScript error in the TableLicense.tsx component. The error occurs because the wrapper ref is defined with an explicit null in its union type, which conflicts with React's expected ref types.

Changes

  • Modified the type definition of wrapper ref in TableLicense.tsx and Table.tsx from RefObject<HTMLDivElement | null> to RefObject

Issue

Fixes: #624

Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@heliocastro heliocastro self-requested a review March 17, 2025 07:01
@harshitg927 harshitg927 changed the title Fix: TypeScript build failure in TableLicense component's RefObject definition Fix(build): TypeScript build failure in TableLicense component's RefObject definition Mar 17, 2025
@harshitg927 harshitg927 changed the title Fix(build): TypeScript build failure in TableLicense component's RefObject definition fix(build): TypeScript build failure in TableLicense component's RefObject definition Mar 17, 2025
@harshitg927 harshitg927 changed the title fix(build): TypeScript build failure in TableLicense component's RefObject definition fix(build): TypeScript build failure in TableLicense and Table components' RefObject definition Mar 25, 2025
@hoangnt2
Copy link
Contributor

hoangnt2 commented Mar 26, 2025

Hi @harshitg927 , I fixed build error in #650.
Maybe it is not related to the Table component

@hoangnt2 hoangnt2 closed this May 30, 2025
@hoangnt2
Copy link
Contributor

This error was fixed by ##650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Failure: TypeScript Error in RefObject Definition in TableLicense Component
3 participants