Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(openapi): add OpenAPI doc for ComponentController #2155

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Oct 19, 2023

Please provide a summary of your changes here.

Add OpenAPI docs using springdoc for ComponentController /component

Continuation of #2071

Note: The properties setVisbility and setBusinessUnit were documented in the SpringDoc. However, they appear to be artifacts of thrift. Please let me know if they should exist and I will revert the changes.

Suggest Reviewer

@heliocastro
@KoukiHama
@ag4ums

How To Test?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

Add OpenAPI docs using springdoc for ComponentController

Signed-off-by: Gaurav Mishra <gmishx@gmail.com>
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
image

@ag4ums ag4ums added ready ready to merge and removed needs code review labels Nov 7, 2023
@ag4ums ag4ums merged commit bfa8b19 into eclipse-sw360:main Nov 7, 2023
1 check passed
@GMishx GMishx deleted the doc/api/openapi branch November 7, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants