Revert "fix(importCDX): Resolved unnecessary update of component fields" #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMishx
added
needs code review
needs general test
|
@sameed20 please test this PR. |
afsahsyeda
force-pushed
the
revert-2138-fix/sbom-import-affecting-already-present-components
branch
from
0627105 to
a08ff36
Compare
afsahsyeda
requested review from
heliocastro,
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
|
@sameed20 Please test this PR. |
afsahsyeda
force-pushed
the
revert-2138-fix/sbom-import-affecting-already-present-components
branch
from
a08ff36 to
6049ecc
Compare
afsahsyeda
requested review from
sameed20
and removed request for
heliocastro,
ag4ums,
GMishx,
KoukiHama and
arunazhakesan
afsahsyeda
force-pushed
the
revert-2138-fix/sbom-import-affecting-already-present-components
branch
from
6049ecc to
afd956d
Compare
afsahsyeda
added
ready
GMishx
deleted the
revert-2138-fix/sbom-import-affecting-already-present-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2138
The component is being updated only if the specific fields are empty which is the expected behavior. This feature prevents the CDX component type from being in the component and also removes the feature of merging different component descriptions using the "||" operator.