Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(report): refactor /reports endpoint #2818

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix(report): refactor /reports endpoint #2818

merged 2 commits into from
Dec 18, 2024

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Dec 16, 2024 •
edited
Loading

Please provide a summary of your changes here.

  1. Fix OpenAPI docs for the /reports endpoint.
  2. Refactor /reports endpoint to expose all hidden parameters.
  3. Modify source bundle to use attachment usage to generate bundle.
  4. Do not update attachment usage based on report generation. Should be changed with /attachmentUsage endpoint only.

Suggest Reviewer

@keerthi-bl

How To Test?

Generate different reports with /reports endpoint to check all parameters.

@GMishx
fix(doc): fix OpenAPI docs for report controller
d6fc66f 
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for New-UI Level for the API and UI level changes for the new-ui labels Dec 16, 2024
@GMishx GMishx force-pushed the fix/report/refactor-inputs branch from d794908 to ce9c4e2 Compare December 16, 2024 06:10
@GMishx
fix(report): refactor /reports endpoint
6f970b7 
1. Refactor /reports endpoint to expose all hidden parameters.
2. Modify source bundle to use attachment usage to generate bundle.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx GMishx force-pushed the fix/report/refactor-inputs branch from ce9c4e2 to 6f970b7 Compare December 16, 2024 06:38
@keerthi-bl
Copy link
Contributor

Code looks good. Test and review completed.

image

image

@keerthi-bl keerthi-bl removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Dec 18, 2024
@keerthi-bl keerthi-bl self-requested a review December 18, 2024 05:25
keerthi-bl
keerthi-bl approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@keerthi-bl keerthi-bl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@GMishx GMishx added the ready ready to merge label Dec 18, 2024
@GMishx GMishx merged commit aadf189 into eclipse-sw360:main Dec 18, 2024
3 checks passed
@GMishx GMishx deleted the fix/report/refactor-inputs branch December 18, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keerthi-bl keerthi-bl keerthi-bl approved these changes

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

Assignees
No one assigned
Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GMishx @keerthi-bl