Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support special AID treatment for ranges #1129

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

danielpeintner
Copy link
Member

fixes #1128

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@relu91
Copy link
Member

relu91 commented Oct 19, 2023

It seems we have dangling and random failing macos tests for node 18 😢 . But they are not related to this PR.

@JKRhb
Copy link
Member

JKRhb commented Oct 19, 2023

It seems we have dangling and random failing macos tests for node 18 😢 . But they are not related to this PR.

Yeah, I now restarted the workflow a second time, if it keeps failing then maybe we need to exclude this combination from the CI :/

@JKRhb
Copy link
Member

JKRhb commented Oct 19, 2023

Okay, now it worked 🤔 OPC UA seems to be a bit unreliable here :/

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (595d818) 77.39% compared to head (de60e48) 75.73%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1129      +/-   ##
==========================================
- Coverage   77.39%   75.73%   -1.66%     
==========================================
  Files          80       80              
  Lines       16159    16245      +86     
  Branches     1519     1528       +9     
==========================================
- Hits        12506    12303     -203     
- Misses       3632     3897     +265     
- Partials       21       45      +24     
Files Coverage Δ
...s/td-tools/src/util/asset-interface-description.ts 79.34% <36.95%> (-3.92%) ⬇️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@relu91 relu91 merged commit c14d4dd into eclipse-thingweb:master Oct 19, 2023
11 checks passed
@relu91
Copy link
Member

relu91 commented Oct 19, 2023

Okay, now it worked 🤔 OPC UA seems to be a bit unreliable here :/

Yeah, we have to dig deeper, it might be some un-closed resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AID and ranges
3 participants