Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve GitHub runner issues on MacOs #1155

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

danielpeintner
Copy link
Member

fixes #1154

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (2976374) 76.60% compared to head (9f3f7d7) 76.57%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   76.60%   76.57%   -0.03%     
==========================================
  Files          80       80              
  Lines       16578    16600      +22     
  Branches     1596     1601       +5     
==========================================
+ Hits        12699    12712      +13     
- Misses       3852     3861       +9     
  Partials       27       27              
Files Coverage Δ
...s/td-tools/src/util/asset-interface-description.ts 71.90% <66.66%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner
Copy link
Member Author

danielpeintner commented Nov 7, 2023

failing tests, but this is different since it fails for MQTT

https://github.com/eclipse-thingweb/node-wot/actions/runs/6781375943/job/18431555492?pr=1155#step:8:399

EDIT: re-running helped in this case...

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I would merge this and treat MQTT problems in other PR.

@danielpeintner danielpeintner merged commit e25cbd9 into eclipse-thingweb:master Nov 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Runner on MacOs fails with ModuleNotFoundError
2 participants