feat(core): add helper function to fetch a TD

[danielpeintner]

fixes #1055

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ce79cd) 76.52% compared to head (3d86b80) 76.61%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1169      +/-   ##
==========================================
+ Coverage   76.52%   76.61%   +0.08%     
==========================================
  Files          80       80              
  Lines       16705    16725      +20     
  Branches     1616     1618       +2     
==========================================
+ Hits        12784    12814      +30     
+ Misses       3891     3880      -11     
- Partials       30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[relu91]

Shouldn't we deprecate this helper function and favor the new #1166?

[danielpeintner]

Shouldn't we deprecate this helper function and favor the new #1166?

W.r.t. fetchTD() ... there should be just one piece of code dealing with it, true, point taken 👍.

I am wondering what we should do w.r.t. to the existing fetch(). Remove it? Helpers usually offers static functions, the only exception is fetch() which needs a Servient to work. I would think we should remove the function "on the long run"...

Moreover, there is the interface Resolver which is used by ThingModel code.. this is somewhat not very clear to me.

[relu91]

Yes, I would deprecate the fetch and fetchTD functions in favor of requestThingDescription.

Moreover, there is the interface Resolver which is used by ThingModel code.. this is somewhat not very clear to me.

The interface is there to not depend on the Core from the ThingModelHelpers pov. Users can decide to use the ThingModel helpers without using the Core package and implement their own resolver. I think we can appreciate this choice when we move the tool to a new repo.

[danielpeintner]

Yes, I would deprecate the fetch and fetchTD functions in favor of requestThingDescription.

deprecate fetch is possible but at the moment it is still used.
Let's wait till #1166 has been integrated and take a look to replace all usages.
Anyhow, ThingModel still uses fetch.. I believe.. but let's see...

deprecate fetchTD is not necessary since it hasn't been pushed yet.

[danielpeintner]

Closing in favor of #1183