ci: add a total timeout of 30 minutes #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1178 +/- ##
=======================================
Coverage 76.33% 76.33%
=======================================
Files 80 80
Lines 16829 16829
Branches 1615 1615
=======================================
Hits 12847 12847
Misses 3952 3952
Partials 30 30 ☔ View full report in Codecov by Sentry. |
danielpeintner
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
LGTM.
Do we still need
node-wot/.github/workflows/ci.yaml
Lines 50 to 52 in 6c13206
Maybe yes to be able to detect problems earlier, right
Yeah, exactly, would probably still be useful to have that time-limit as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of #1175, I noticed that the codecov step was somehow hanging for over 2 hours without causing the CI to fail. To address the issue, this PR proposes to add an additional "total" timeout value of 30 minutes for the whole job which should be enough to cover all runs that work as intended.