test(coap-server): don't shutdown servient unnecessarily

[JKRhb]

This PR contains a potential fix for the CoAP server problems observed in #1195. As the servients are not used by the CoapServer class, I simply removed the invocations of shutdown to fix the issue at hand.

In general, I think we could discuss if passing the servient to the protocol interface implementations is actually necessary or if the passing of protocol-specific callbacks for retrieving credentials could be an alternative (this is the approach I used for dart_wot in the meantime). But I would open a dedicated issue for that later :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5dc47c4) 77.60% compared to head (dec7291) 77.59%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
- Coverage   77.60%   77.59%   -0.02%     
==========================================
  Files          83       83              
  Lines       17311    17311              
  Branches     1747     1747              
==========================================
- Hits        13435    13433       -2     
- Misses       3840     3842       +2     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[relu91]

Good to go too, should we merge this first or maybe try it after we merged #1195 ?

[JKRhb]

Good to go too, should we merge this first or maybe try it after we merged #1195 ?

Either way would be fine for me :) If we merge #1195 first, then I would rebase against the new master state.

[danielpeintner]

I would merge this PR before #1195 so that we have clean runs for all PRs that we merge. I hope this is okay for all..