[4.4.x] Ensure that the task is not in the tasks queue when it is rejected from the executor #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om the executor Closes eclipse-vertx#4900
|
Update: Quarkus confirmed they will stay on 4.4.x for a while, so I'd appreciate this backport to 4.4.x and eventually a release. |
|
yeah we should merge it but we are now focusing on 4.5 release, so it will take some time before we do a 4.4.x release as we will try to accumulate more fixes than just this |
|
This sounds fine, let's merge now and wait until some more bits accumulate. As I wrote earlier, the Quarkus team said they might not immediately go for 4.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4900
This is backport of the PR #4904 as the Keycloak project and Quarkus' LTS 3.2 are still on Vert.x 4.4.x.
It would be great if this could could eventually make it into a 4.4.x release. Not sure when and if the Quarkus team would upgrade, I will need to check that separately.
@vietj - I'd be happy if you could have a look as you've reviewed the original PRs. Thanks!