Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] avoid accessing potentially non-existing property supporting_arrays. #65

Closed
wants to merge 1 commit into from

Conversation

fprill
Copy link
Contributor

@fprill fprill commented Jan 8, 2025

No description provided.

@FussyDuck
Copy link

FussyDuck commented Jan 8, 2025

CLA assistant check
All committers have signed the CLA.

floriankrb
floriankrb previously approved these changes Jan 8, 2025
@anaprietonem anaprietonem added the bug Something isn't working label Jan 9, 2025
Copy link
Member

@JPXKQX JPXKQX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fprill, the "supporting_arrays" property has been introduced as a new dataset property recently. I recommend incorporating it into your dataset if it is not already included.

@MeraX
Copy link
Contributor

MeraX commented Jan 9, 2025

Hi @JPXKQX , I might have missed an update, but I could not find this property it in the Anemoi Dataset data model documentation at https://confluence.ecmwf.int/display/MLPP/%5B4.4.2%5D+Define%2C+consolidate%2C+and+implement+the+Anemoi-Dataset+data+model . Could you update the documentation and explain the supporting_arrays property?

Is supporting_arrays actually necessary or could we make it optional to preserve backward compatibility?

@b8raoult
Copy link
Collaborator

b8raoult commented Jan 9, 2025

@MeraX , the supporting_arrays is a method that will return a dictionary of numpy arrays to put in the checkpoint, The most important ones are latitudes and longitudes so that anemoi-inference can know the grid. Other arrays are mostly used for LAMs. anemoi-datasets and anemoi-training were updated in sync for that feature to work.

@fprill
Copy link
Contributor Author

fprill commented Jan 11, 2025

Hello, with the PR ecmwf/anemoi-datasets#170 this PR is now actually obsolete: The problem was that we previously had to apply version pinning to an older version for anemoi-datasets. Now the supporting_arrays property is available in our codebase, because with PR 170 we can use the current develop branch of anemoi-datasets.
Many thanks for the thorough reviewing and the quick support!

@fprill fprill closed this Jan 11, 2025
@JPXKQX JPXKQX deleted the fix/supporting_arrays branch January 13, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants