-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Reinstantiate CI files #75
base: develop
Are you sure you want to change the base?
Conversation
Hi Jesper, I went through the yaml files. Most of them look uncontroversial to me. However, the |
- name: Detect changed packages | ||
id: changed-packages | ||
run: | | ||
CHANGED_FILES=$(git diff --name-only ${{ github.event.before }} ${{ github.sha }}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to understand this line. As I understand it, it checks if there are changes between the commit pushed to develop
(${{ github.sha }}
and the previous HEAD of develop
${{ github.event.before }}
. Subsequently, you install any of the three packages from the repository, if there were and changes and use PyPI otherwise.
Does this assume, that the previous HEAD of develop
is always equal to the version on PyPI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried not to make implicit assumptions here. I thought it makes most sense to try and see if there are any changes compared to the previous version on develop
and not necessarily the released version.
Another thing that came to my mind: You are installing the three |
Oh that's a problem. Wasn't aware of that limitation. |
This now runs the tests of changed code against:
This mimics the way all other code in Anemoi currently runs, specifically against the released versions of other packages.
This ensures that the code will stay up to date with coming changes on develop. Current limitationsThis can mean that if there are changes on develop that are not backwards compatible, but also aren't released yet, then some of the tests will fail. I believe it's important to test both against released and current code on develop. so I added the label |
This PR adds the following workflows:
These depend on merge of: