Update decoders; restore (optional) OPL MIDI support #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates some decoders (the ones based around FM synthesis) to use their libraries' native formats and adjusts the maximum allowable playback frequency in case the native device's is too high for it.
Also restores OPL MIDI playback as a compile-time option and integrates it into the MIDI Instrument Set selection in the Sound Options menu. If no GENMIDI lump, or a pack file named GENMIDI with an .op2, .opl, .ad, .tmb, or .wopl extension is found, it will fallback to an internal set of default instruments.