Add: escape ff127 option (#353)

README.md

@@ -220,6 +220,13 @@ If you find that the filename includes an emoji and the browser can't save the i
 
 See also: [#175](https://github.com/eight04/image-picka/issues/175)
 
+Illegal filename bug in Firefox 127
+----------------------------------
+
+There is a bug in Firefox 127 that throws an error when downloading a file with a filename that contains a percentage, spaces, or dot.
+
+See also: [#347](https://github.com/eight04/image-picka/issues/347)
+
 Translation
 -----------
 

src/lib/escape.js

@@ -61,7 +61,16 @@ function trimString(s) {
 }
 
 export function escapePath(path) {
-  return path.split(/\\|\//g).map(component =>
-    trimString(component).replace(/^\.+|\.+$/g, m => "．".repeat(m.length))
+  const parts = path.split(/\\|\//g);
+  return parts.map((component, i) => {
+    component = trimString(component).replace(/^\.+|\.+$/g, m => "．".repeat(m.length))
+    if (pref.get("escapeFF127")) {
+      component = component.replace(/%/g, "％");
+      if (i < parts.length - 1) {
+        component = component.replace(/\./g, "．");
+      }
+    }
+    return component;
+  }
   ).join("/");
 }

src/lib/pref.js

@@ -30,6 +30,7 @@ const DEFAULT = {
   downloadButtonPositionVertical: "TOP_OUTSIDE",
   escapeWithUnicode: true,
   escapeZWJ: false,
+  escapeFF127: shouldEscapeFF127(),
   isolateTabs: false,
   filenameConflictAction: "uniquify",
   saveAs: false,
@@ -87,3 +88,13 @@ async function init() {
   await Promise.all(pending);
   await browser.storage.local.set({prefInSync: true});
 }
+
+function shouldEscapeFF127() {
+  const ua = navigator.userAgent;
+  const isFirefox = /Firefox/.test(ua);
+  if (!isFirefox) {
+    return false;
+  }
+  const version = ua.match(/Firefox\/(\d+)/)[1];
+  return parseInt(version, 10) >= 127;
+}

src/options.js

@@ -312,6 +312,12 @@ const root = createUI({
           label: _("optionEscapeZWJLabel"),
           learnMore: "https://github.com/eight04/image-picka#zero-width-joiner"
         },
+        {
+          type: "checkbox",
+          key: "escapeFF127",
+          label: _("optionEscapeFF127Label"),
+          learnMore: "https://github.com/eight04/image-picka#illegal-filename-bug-in-firefox-127"
+        },
         {
           type: "text",
           key: "srcAlternative",

src/static/_locales/en/messages.json

@@ -283,6 +283,10 @@
 		"message": "Button size",
 		"description": "Label of downloadButtonSize option"
 	},
+  "optionEscapeFF127Label": {
+    "message": "Escape dot and percentage in the filename to avoid Firefox 127 bug.",
+    "description": "Label of escapeFF127 option"
+  },
 	"optionEscapeWithUnicodeLabel": {
 		"message": "Escape special characters into Unicode glyphs.",
 		"description": "Label of escapeWithUnicode option"