Use http4s' new Part.filename method #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
|
@eikek could you have a look at this? |
|
Thank you and sorry for the delay. I'm having a bit of a hard time currently. I'll be slow to respond for a while, hopefully starting better next year ;-) |
|
Unfortunate that ci files, I think I had that issue earlier but it somehow disappeared. I'll fix that in the coming days |
this reencodes the filename as UTF-8, which is probably a safe bet.
pschichtel
force-pushed
the
bugfix/upload-filename-encoding
branch
from
d3f452e to
1783714
Compare
|
@eikek fixed and rebased this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this reencodes the filename as UTF-8, which is probably a safe bet.
this should close #2825