Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot: use directories and use docker ecosystem #4017

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 26, 2025

What does this pull request do?

Use dependabot for updating docker images stored in our internal docker registry using this.

Use directories to manage the dependencies for the GitHub workflows and composite actions.

Why

We already have secrets stored for accessing the internal docker registry. Use one dependency management tool with native support for GitHub actions and the GH secrets access control.

This has been already tested in the past in a sandbox repository and also in other GH internal repositories.

Actions

  • Create Dependabot GitHub secret using CasC.

Related issues

See elastic/apm-agent-nodejs#4539 and elastic/apm-agent-python#2246

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.next-release.md
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.next-release.md
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.md
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@v1v v1v requested review from a team March 27, 2025 09:09
@v1v v1v enabled auto-merge (squash) March 27, 2025 14:54
@v1v v1v merged commit d6ab70a into elastic:main Mar 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants