Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tracing to kafka health functions #319

Closed
wants to merge 1 commit into from
Closed

feat: add tracing to kafka health functions #319

wants to merge 1 commit into from

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Nov 7, 2023 •
edited by marclop
Loading

No description provided.

@kruskall kruskall requested a review from a team November 7, 2023 17:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

⚠️ Warning

System-tests will not be executed for this PR because it is from a forked repository.
But it will still create a successful run-system-tests status check.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

⚠️ Warning

System-tests will not be executed for this PR because it is from a forked repository.
But it will still create a successful run-system-tests status check.

marclop
marclop reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unconvinced this is the right approach. This will add tracing to every Kafka ping, which isn't very useful.

@kruskall kruskall closed this Nov 16, 2023
@kruskall kruskall deleted the feat/health-tracing branch November 20, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclop marclop marclop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kruskall @marclop