Wrap errors with additional information #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code implicitly returns this occurrence of err only if err = nil. Change it to nil instead to reduce confusion.
|
kruskall
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apm-queueis a library, which leads to these errors surfacing in other code.Debugging errors from libraries is painful without clear indication of where the error comes from.
To help with debugging this PR wrap errors with additional details.
One change that affects an
errvariable but is not an addition is the removal of areturn errinpubsublite/topiccreator.go. The function handles the caseerr != nilseparately so the only case in which thatreturn errwas executed was onerr = nil. To increase clarity I changed it to directlyreturn nil.