fix: better protect against nil topicAttributeFunc #618
+24
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set the default func in the common config instead of the metrics hook
|
rubvs
approved these changes
Jan 16, 2025
|
@kruskal I also think it makes sense to not open PRs from your fork, since that skips the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Why is this being changed
systemtests are failing because of a nil topic attribute func. The topic manager does not handle nil func.
See https://github.com/elastic/apm-queue/actions/runs/12741942829/job/35509307227
🧑💻 What is being changed
set the default func in the common config instead of the metrics hook
✅ How to validate the change
run systemtests