Relocate libbeat output & instrumentation #9247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @axw? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
axw
force-pushed
the
relocate-libbeat-output
branch
2 times, most recently
from
736635a to
03f4125
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
📚 Go benchmark reportDiff with the report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
axw
force-pushed
the
relocate-libbeat-output
branch
2 times, most recently
from
27b4e88 to
188a8f5
Compare
This is something that should run just once for the lifetime of the process. I'm intending to move the reload logic out of beater and into beatcmd (or a subpackage).
Move initialisation of libbeat output (publisher/pipeline) and instrumentation (APM tracer) to package beater. Some of the complexity around reloading is reduced as now have full control over creating the libbeat output. Similarly, we can reduce complexity related to the "tracer server" by running it per reloaded server.
axw
force-pushed
the
relocate-libbeat-output
branch
from
188a8f5 to
3669a35
Compare
simitt
approved these changes
Oct 12, 2022
| ctx, reload.ReloadableFunc(reloader.reloadOutput), | ||
| ) | ||
| }) | ||
| reload.Register.MustRegister("output", reload.ReloadableFunc(reloader.reloadOutput)) |
There was a problem hiding this comment.
Why was this done in its own go routine before (and is not necessary anymore)?
There was a problem hiding this comment.
Previously libbeat registered the reloader, and we added our own reloader. IIRC there was a timing issue that meant we had to register the hook before the "reloader" was created. So what we did was created a channel, and then received requests off that channel after starting the server.
We no longer handle output reloading in libbeat or in beatcmd, so we can simplify it all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Move the automaxprocs adjustment code to package beatcmd, since it should run only once for the process's lifetime. Move creation of the libbeat output pipeline, and APM instrumentation, to package beater, as these can both be reloaded/reconfigured.
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Update package changelog.yml (only if changes toapmpackagehave been made)- [ ] Documentation has been updatedHow to test these changes
N/A
Related issues
Part of #8928
Closes #9074