[8.x](backport #40909) [filebeat] Fix long filepaths in diagnostics exceeding max path limits on Windows #40923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…s on Windows (#40909) * [filebeat] Fix long filepaths in diagnostics exceeding max path limits on Windows * Update changelog with PR number * Adjust utz * Quiet the linter false positive * More linter pacification * Fix linter complains for errors checks in okta.go * Let the linter complain again * Revert revert (cherry picked from commit d82fe9a)
mergify
bot
requested review from
mauri870 and
khushijain21
and removed request for
a team
botelastic
bot
added
the
needs_team
aleksmaus
added
the
Team:Security-Deployment and Devices
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
botelastic
bot
removed
the
needs_team
|
This pull request has not been merged yet. Could you please review and merge it @aleksmaus? 🙏 |
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
mauri870
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fix long filepaths in diagnostics exceeding max path limits on Windows.
Following the first proposal here
elastic/elastic-agent#3758 (comment)
Added
IDWithoutNamethat doesn't include the source name and using that instead.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Screenshots
The screenshot that shows the diagnostics collected before and after this change. The earlier diagnostics shows the long path that includes the sanitized okta log collection URL. The diagnostics after this change have shorter path that doesn't include the sanitized URL in the path.
This is an automatic backport of pull request #40909 done by [Mergify](https://mergify.com).