Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17](backport #42401) Handle authorization errors in Kafka output #42844

Closed
wants to merge 8 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 21, 2025

Proposed commit message

When there is an authorisation error in the Kafka output, the events are dropped and an error message is logged.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Disruptive User Impact
## Author's Checklist

How to test this PR locally

Run the tests added by this PR:

mage buildSystemTestBinary
go test -tags integration -run=TestAuthorisationErrors -v ./tests/integration

If you want to run any Beat yourself, you can modify the test so it only starts the mock and waits, then configure a Beat to connect to it.

Related issues

## Use cases
## Screenshots
## Logs


This is an automatic backport of pull request #42401 done by Mergify.

When there is an authorisation error in the Kafka output, the events
are dropped and an error message is logged.

(cherry picked from commit 5720300)
@mergify mergify bot added the backport label Feb 21, 2025
@mergify mergify bot requested a review from a team as a code owner February 21, 2025 16:54
@mergify mergify bot requested review from mauri870 and faec and removed request for a team February 21, 2025 16:54
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 21, 2025
Copy link
Contributor Author

mergify bot commented Feb 24, 2025

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

Copy link
Contributor Author

mergify bot commented Mar 3, 2025

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

Copy link
Contributor Author

mergify bot commented Mar 10, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.17/pr-42401 upstream/mergify/bp/8.17/pr-42401
git merge upstream/8.17
git push upstream mergify/bp/8.17/pr-42401

Copy link
Contributor Author

mergify bot commented Mar 10, 2025

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 11, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 11, 2025
@belimawr
Copy link
Contributor

CI is failing due to a DNS issue while downloading Go modules: #43044

@belimawr
Copy link
Contributor

Because of #43250, let's not merge it for now.

We might want to merge it once the fix for #43250 is ready so we don't get merge conflicts.

Copy link
Contributor Author

mergify bot commented Mar 17, 2025

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

1 similar comment
Copy link
Contributor Author

mergify bot commented Mar 24, 2025

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

Copy link
Contributor Author

mergify bot commented Mar 31, 2025

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

@pierrehilbert
Copy link
Collaborator

pierrehilbert commented Apr 1, 2025

@belimawr What is the update for this backport?

@belimawr
Copy link
Contributor

belimawr commented Apr 1, 2025

@belimawr What is the update for this backport?

It is the same as before (see #42844 (comment)). When I was talking with Fae about this issue, we understood that it was better not to merge this PR, so at least 8.17.x is not affected by #43250.

Let's have a chat if you want to further discuss this.

@pierrehilbert
Copy link
Collaborator

So why not closing that one?

@belimawr
Copy link
Contributor

belimawr commented Apr 1, 2025

So why not closing that one?

The current idea is the the fix will build on top of those changes as they have been merged on main already, so once we have the fix, we can merge this PR and then backport the final fix. This way avoid merge conflicts caused by fixing #43250 on a codebase that includes this backport.

However, thinking about it, I can add a note to #43250 about this PR and close it. So at least we don't keep a pending backport open.

Thanks @pierrehilbert !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants