-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.17](backport #42401) Handle authorization errors in Kafka output #42844
Conversation
When there is an authorisation error in the Kafka output, the events are dropped and an error message is logged. (cherry picked from commit 5720300)
This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏 |
This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏 |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏 |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
CI is failing due to a DNS issue while downloading Go modules: #43044 |
This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏 |
1 similar comment
This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏 |
This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏 |
@belimawr What is the update for this backport? |
It is the same as before (see #42844 (comment)). When I was talking with Fae about this issue, we understood that it was better not to merge this PR, so at least 8.17.x is not affected by #43250. Let's have a chat if you want to further discuss this. |
So why not closing that one? |
The current idea is the the fix will build on top of those changes as they have been merged on However, thinking about it, I can add a note to #43250 about this PR and close it. So at least we don't keep a pending backport open. Thanks @pierrehilbert ! |
Proposed commit message
When there is an authorisation error in the Kafka output, the events are dropped and an error message is logged.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
Run the tests added by this PR:
If you want to run any Beat yourself, you can modify the test so it only starts the mock and waits, then configure a Beat to connect to it.
Related issues
## Use cases## Screenshots## LogsThis is an automatic backport of pull request #42401 done by Mergify.