[8.18](backport #43409) bump elastic-agent-system-metrics #43423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* chore: go.mod * chore: go.mod * changelog (cherry picked from commit 754ad98) # Conflicts: # NOTICE.txt # go.mod # go.sum
mergify
bot
added
backport
conflicts
|
Cherry-pick of 754ad98 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
botelastic
bot
added
the
needs_team
github-actions
bot
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
|
This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏 |
VihasMakwana
force-pushed
the
mergify/bp/8.18/pr-43409
branch
from
85602ce to
a76b647
Compare
|
This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏 |
VihasMakwana
added a commit
to elastic/elastic-agent-system-metrics
that referenced
this pull request
Apr 2, 2025
Follows #210 beats 8.x is on go 1.23.6, whereas elastic-agent-system-metrics's go.mod is on 1.23.7 The [test cases are failing](https://buildkite.com/elastic/beats-xpack-agentbeat/builds/10319#0195e73f-5a26-4c7b-8050-ac1d129a0d4f) due to mismatch of go versions on [backport PR](elastic/beats#43423). I think the best thing to do here is to change elastic-agent-system-metrics's go.mod to 1.23.0, rather than updating the backport PR. If anyone has a better suggestion, feel free to share.
VihasMakwana
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update elastic-agent-system-metrics
Closes #42593
This is an automatic backport of pull request #43409 done by Mergify.