Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Asset Inventory][Azure] Do not add --install-servers flag for versions < 9.0 #3142

Merged
merged 2 commits into from
Mar 26, 2025
Merged

[Asset Inventory][Azure] Do not add --install-servers flag for versions < 9.0 #3142

merged 2 commits into from
Mar 26, 2025

Conversation

kubasobon
Copy link
Member

Summary of your changes

Fixes an issue where releases earlier than 9.0 also got an --install-servers flag. Using the same code as regular Azure install script.

Related Issues

Fixes https://github.com/elastic/security-team/issues/11500

@kubasobon kubasobon added the Team:Cloud Security Cloud Security team related label Mar 25, 2025
@kubasobon kubasobon self-assigned this Mar 25, 2025
@kubasobon kubasobon requested a review from a team as a code owner March 25, 2025 09:49
@mergify Mergify
Copy link

mergify bot commented Mar 25, 2025

This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.
    NOTE: backport-v8.x has been added to help with the transition to the new branch 8.x.

@kubasobon kubasobon enabled auto-merge (squash) March 26, 2025 11:17
@kubasobon kubasobon merged commit cc1ed67 into main Mar 26, 2025
9 checks passed
@kubasobon kubasobon deleted the arm-template-90-fix branch March 26, 2025 11:35
mergify bot pushed a commit that referenced this pull request Mar 26, 2025
@kubasobon @mergify
[Asset Inventory][Azure] Do not add --install-servers flag for versio…
bb57161 
…ns < 9.0 (#3142)

do not add --install-servers flag for versions < 9.0

(cherry picked from commit cc1ed67)

# Conflicts:
#	deploy/asset-inventory-arm/install-agent.sh
@mergify mergify bot mentioned this pull request Mar 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orestisfl orestisfl orestisfl approved these changes

Assignees

@kubasobon kubasobon

Labels
backport-v8.x Team:Cloud Security Cloud Security team related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubasobon @orestisfl