Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mockery #3144

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Upgrade mockery #3144

merged 1 commit into from
Mar 25, 2025

Conversation

orestisfl
Copy link
Contributor

Pulling change out of #3143 to ease reviewing.

This is the result of running

hermit upgrade mockery
just validate-mocks

Reason is that old mockery complains about go 1.22's syntax

for i := range 10 {
    ...
}

Pulling change out of elastic#3143 to ease reviewing.

This is the result of running
```shell
hermit upgrade mockery
just validate-mocks
```

Reason is that old mockery complains about go 1.22's syntax
```go
for i := range 10 {
    ...
}
```
@orestisfl orestisfl self-assigned this Mar 25, 2025
@orestisfl orestisfl requested a review from a team as a code owner March 25, 2025 13:16
@orestisfl orestisfl enabled auto-merge (squash) March 25, 2025 13:17
@orestisfl orestisfl merged commit 7d838d1 into elastic:main Mar 25, 2025
8 checks passed
mergify bot pushed a commit that referenced this pull request Mar 25, 2025
Pulling change out of #3143 to ease reviewing.

This is the result of running
```shell
hermit upgrade mockery
just validate-mocks
```

Reason is that old mockery complains about go 1.22's syntax
```go
for i := range 10 {
    ...
}
```

(cherry picked from commit 7d838d1)
orestisfl added a commit that referenced this pull request Mar 25, 2025
Upgrade mockery (#3144)

Pulling change out of #3143 to ease reviewing.

This is the result of running
```shell
hermit upgrade mockery
just validate-mocks
```

Reason is that old mockery complains about go 1.22's syntax
```go
for i := range 10 {
    ...
}
```

(cherry picked from commit 7d838d1)

Co-authored-by: Orestis Floros <orestis.floros@elastic.co>
@orestisfl orestisfl linked an issue Mar 26, 2025 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNVM: Clean-up old snapshots on startup
2 participants