[8.x](backport #3143) cnvm: Delete old snapshots on startup #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
### Summary of your changes
Change CNVM to add a background job cleaning up old snapshots.
The logic here is:
1. Background routine is started. Since the amount of leftover snapshots can be quite high (e.g. 40k in our account), 3 cleanup workers are used
2. `IterOwnedSnapshots()` is called which goes over all snapshots, returning an iterator. Snapshots are selected if:
1. They are more than 48 hours old
2. They have a tag with key "Name" and value starting with "elastic-vulnerability"
3. They are "self-owned"
3. Cleanup returns. On context cancelled, no extra grace period is added so the process doesn't block restarts/shutdown.
### Screenshot/Data
Deleted 1178 snapshots from `2025-03-25T16:17:08.384Z` to `2025-03-25T16:20:19.504Z`
### Related Issues
Closes #3105
Closes https://github.com/elastic/sdh-security-team/issues/1168
### Checklist
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have added the necessary README/documentation (if appropriate)
#### Introducing a new rule?
No
(cherry picked from commit 8860b9d)
orestisfl
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
Change CNVM to add a background job cleaning up old snapshots.
The logic here is:
IterOwnedSnapshots()is called which goes over all snapshots, returning an iterator. Snapshots are selected if:Screenshot/Data
Deleted 1178 snapshots from
2025-03-25T16:17:08.384Zto2025-03-25T16:20:19.504ZRelated Issues
Closes #3105
Closes https://github.com/elastic/sdh-security-team/issues/1168
Checklist
Introducing a new rule?
No
This is an automatic backport of pull request #3143 done by Mergify.