Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name for 'Elasticsearch Service' #344

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Feb 5, 2025

According to the last naming update I've seen, Elasticsearch Service is now Elastic Cloud Hosted.

The {{ess}} attribute has been carried over into the migrated docs, so I think it makes sense to continue using this attribute with the new name.

CC @eedugon, @kosabogi, @shainaraskas since I know you've been working on what were the Cloud docs.

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we might want to add another one that matches the new acronym (ech) for ease of use for contributors as well but can do that separately

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, sorry. thinking for one more second about this. we can't do this because ESS used to have only one meaning, but now it's represented by two concepts - Elastic Cloud and Elastic Cloud Hosted

@shainaraskas
Copy link
Collaborator

I suggest that we add a new dedicated variable and start using it instead to avoid confusion

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Feb 5, 2025

I suggest that we add a new dedicated variable and start using it instead to avoid confusion

@shainaraskas Okay. I've added a new variable instead. I guess the existing "ESS" attributes will need to be reviewed or replaced en masse.

@florent-leborgne
Copy link
Contributor

+1 with adding a new variable and "deprecating" the old one. {{ess}} will need to be replaced by either {{ecloud}} or the new {{ech}} in the sources. I think the content refinement we're doing now as part of the migration is a good opportunity to do that accurately.

With the recent addition of serverless, it might even be wise to check that existing {{ecloud}} occurrences are correct and aren't just meant to designate {{ech}}

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this as an option now!

@kilfoyle kilfoyle requested a review from shainaraskas February 6, 2025 13:48
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!!

@kilfoyle kilfoyle merged commit 2772080 into elastic:main Feb 6, 2025
4 checks passed
charlotte-hoblik added a commit that referenced this pull request Mar 6, 2025
Based on the following task:
elastic/docs-projects#344

---------

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants