-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update name for 'Elasticsearch Service' #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. we might want to add another one that matches the new acronym (ech
) for ease of use for contributors as well but can do that separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, sorry. thinking for one more second about this. we can't do this because ESS used to have only one meaning, but now it's represented by two concepts - Elastic Cloud and Elastic Cloud Hosted
I suggest that we add a new dedicated variable and start using it instead to avoid confusion |
@shainaraskas Okay. I've added a new variable instead. I guess the existing "ESS" attributes will need to be reviewed or replaced en masse. |
+1 with adding a new variable and "deprecating" the old one. {{ess}} will need to be replaced by either {{ecloud}} or the new {{ech}} in the sources. I think the content refinement we're doing now as part of the migration is a good opportunity to do that accurately. With the recent addition of serverless, it might even be wise to check that existing {{ecloud}} occurrences are correct and aren't just meant to designate {{ech}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have this as an option now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty!!
Based on the following task: elastic/docs-projects#344 --------- Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
According to the last naming update I've seen,
Elasticsearch Service
is nowElastic Cloud Hosted
.The
{{ess}}
attribute has been carried over into the migrated docs, so I think it makes sense to continue using this attribute with the new name.CC @eedugon, @kosabogi, @shainaraskas since I know you've been working on what were the Cloud docs.