-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECE - Manage deployments content added #725
Conversation
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Awesome suggestions by Shaina :) Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice and clean. left some comments to take or leave.
re: api info, when things are a little more stable, we might consider a pattern where we add a note saying "you can also do this through the api" and just link to the relevant endpoint
deploy-manage/deploy/cloud-enterprise/working-with-deployments.md
Outdated
Show resolved
Hide resolved
deploy-manage/deploy/cloud-enterprise/working-with-deployments.md
Outdated
Show resolved
Hide resolved
deploy-manage/deploy/cloud-enterprise/working-with-deployments.md
Outdated
Show resolved
Hide resolved
deploy-manage/deploy/cloud-enterprise/working-with-deployments.md
Outdated
Show resolved
Hide resolved
deploy-manage/deploy/cloud-enterprise/working-with-deployments.md
Outdated
Show resolved
Hide resolved
@@ -1,4 +1,7 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider unburying this - maybe it sits between "configure ece" and "manage deployments"?
% ECE API links and information are still pending | ||
* [Elastic Cloud Enterprise RESTful API](asciidocalypse://docs/cloud/docs/reference/cloud-enterprise/restful-api.md) | ||
|
||
## {{es}} API Console [ece-api-console] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider making this a child page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not a child page in Cloud docs (see this).
Anyway initially I had considered it as a child doc too, so I have no issues on adding it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave is as it is because we'll still have to refine a bit Tools and APIs documentation, as is in progress.. we can create the child page later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice and clean. left some comments to take or leave.
re: api info, when things are a little more stable, we might consider a pattern where we add a note saying "you can also do this through the api" and just link to the relevant endpoint
Applying Shaina's suggestions Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Next and hopefully final PR for ECE content https://github.com/elastic/docs-projects/issues/339
Pages to review:
Notes: