Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECE - Manage deployments content added #725

Merged
merged 35 commits into from
Mar 14, 2025
Merged

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Mar 10, 2025

Next and hopefully final PR for ECE content https://github.com/elastic/docs-projects/issues/339

Pages to review:

Notes:

  • Tools and APIs is still in progress / pending
  • We still need to integrate the information and links about managing ECE through APIs. I haven't included any of this in my last PRs because I don't really know where this info is. We can include that at a later stage.

eedugon and others added 28 commits February 25, 2025 14:18
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Awesome suggestions by Shaina :)

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@eedugon eedugon requested a review from shainaraskas March 10, 2025 22:07
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice and clean. left some comments to take or leave.

re: api info, when things are a little more stable, we might consider a pattern where we add a note saying "you can also do this through the api" and just link to the relevant endpoint

@@ -1,4 +1,7 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider unburying this - maybe it sits between "configure ece" and "manage deployments"?

% ECE API links and information are still pending
* [Elastic Cloud Enterprise RESTful API](asciidocalypse://docs/cloud/docs/reference/cloud-enterprise/restful-api.md)

## {{es}} API Console [ece-api-console]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider making this a child page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a child page in Cloud docs (see this).
Anyway initially I had considered it as a child doc too, so I have no issues on adding it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave is as it is because we'll still have to refine a bit Tools and APIs documentation, as is in progress.. we can create the child page later on.

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice and clean. left some comments to take or leave.

re: api info, when things are a little more stable, we might consider a pattern where we add a note saying "you can also do this through the api" and just link to the relevant endpoint

eedugon and others added 4 commits March 11, 2025 22:02
Applying Shaina's suggestions

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@eedugon eedugon merged commit c278b91 into elastic:main Mar 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants