-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand guidance on testing an upgrade #964
Expand guidance on testing an upgrade #964
Conversation
Call out specifically to look for cluster stability, performance, and snapshot repository bugs. Relates elastic/stack-docs#3009
9237514
to
8b102da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
::: | ||
|
||
:::{tip} | ||
During your upgrade tests, pay particular attention to the following aspects: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we've dispensed with the definition list approach here, very interesting. 🤓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah AIUI the recognised syntax for doing this in Markdown would be ...
Term
: Definition
... but apparently the variant of Markdown we use here doesn't understand that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should I think: https://elastic.github.io/docs-builder/syntax/definition-lists/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
followed by a colon and at least one space (
:
) on the next line
Experiment shows it needs to be at least three spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so good to me I'm actually going to approve this time
Call out specifically to look for cluster stability, performance, and snapshot repository bugs.
Relates elastic/stack-docs#3009