Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand guidance on testing an upgrade #964

Merged

Conversation

DaveCTurner
Copy link
Contributor

Call out specifically to look for cluster stability, performance, and snapshot repository bugs.

Relates elastic/stack-docs#3009

@DaveCTurner DaveCTurner added the documentation Improvements or additions to documentation label Mar 28, 2025
Call out specifically to look for cluster stability, performance, and
snapshot repository bugs.

Relates elastic/stack-docs#3009
@DaveCTurner DaveCTurner force-pushed the 2025/03/28/upgrade-test-guidance branch from 9237514 to 8b102da Compare March 28, 2025 10:15
@DaveCTurner DaveCTurner requested a review from leemthompo March 28, 2025 10:15
@DaveCTurner DaveCTurner marked this pull request as ready for review March 28, 2025 10:15
@DaveCTurner
Copy link
Contributor Author

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:::

:::{tip}
During your upgrade tests, pay particular attention to the following aspects:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we've dispensed with the definition list approach here, very interesting. 🤓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah AIUI the recognised syntax for doing this in Markdown would be ...

    Term
    : Definition

... but apparently the variant of Markdown we use here doesn't understand that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

followed by a colon and at least one space (: ) on the next line

Experiment shows it needs to be at least three spaces.

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so good to me I'm actually going to approve this time

@DaveCTurner DaveCTurner merged commit 5a91b81 into elastic:main Mar 28, 2025
4 checks passed
@DaveCTurner DaveCTurner deleted the 2025/03/28/upgrade-test-guidance branch March 28, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants