Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade notes for logsdb mode #982

Merged
merged 6 commits into from
Apr 1, 2025
Merged

Upgrade notes for logsdb mode #982

merged 6 commits into from
Apr 1, 2025

Conversation

kkrik-es
Copy link
Contributor

Provide a rough estimate on indexing throughput impact.

Add note for upgrading to 9.x.

@kkrik-es kkrik-es added the documentation Improvements or additions to documentation label Mar 31, 2025
@kkrik-es kkrik-es self-assigned this Mar 31, 2025
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kkrik-es and others added 2 commits March 31, 2025 17:15
Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I suggested some small tweaks for clarity/style but otherwise LGTM.

marciw and others added 2 commits March 31, 2025 14:54
@@ -181,4 +181,4 @@ The `logsdb` index mode uses the following settings:

## Notes about upgrading to Logsdb [upgrade-to-logsdb-notes]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, meant to suggest changes to the heading too. You could also try something like "Apply logsdb index mode" for the heading -- up to you.

Suggested change
## Notes about upgrading to Logsdb [upgrade-to-logsdb-notes]
## Upgrade to logsdb [upgrade-to-logsdb]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this, sent #992

@kkrik-es kkrik-es enabled auto-merge (squash) April 1, 2025 05:50
@kkrik-es kkrik-es merged commit da9e87e into main Apr 1, 2025
3 of 4 checks passed
@kkrik-es kkrik-es deleted the logsdb-upgrade-9x branch April 1, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants