-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade notes for logsdb mode #982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I suggested some small tweaks for clarity/style but otherwise LGTM.
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
@@ -181,4 +181,4 @@ The `logsdb` index mode uses the following settings: | |||
|
|||
## Notes about upgrading to Logsdb [upgrade-to-logsdb-notes] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, meant to suggest changes to the heading too. You could also try something like "Apply logsdb index mode" for the heading -- up to you.
## Notes about upgrading to Logsdb [upgrade-to-logsdb-notes] | |
## Upgrade to logsdb [upgrade-to-logsdb] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this, sent #992
Provide a rough estimate on indexing throughput impact.
Add note for upgrading to 9.x.