Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds instructions for customers to complete their AWS annual subscription registration #990

Merged
merged 6 commits into from
Apr 4, 2025

Conversation

kwabena-ansah
Copy link
Contributor

@kwabena-ansah kwabena-ansah commented Apr 1, 2025

@kwabena-ansah kwabena-ansah added the documentation Improvements or additions to documentation label Apr 1, 2025
@kwabena-ansah kwabena-ansah self-assigned this Apr 1, 2025
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kwabena-ansah!

I see the page is hidden here, but not in the asciidoc counterpart, which one should it be?

kwabena-ansah and others added 2 commits April 2, 2025 10:51
Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
@kwabena-ansah
Copy link
Contributor Author

I see the page is hidden here, but not in the asciidoc counterpart, which one should it be?

Yea I don't think it should be hidden but I did it for consistency with the others. Should I unhide all of these as well ?

- hidden: deploy/elastic-cloud/create-monthly-pay-as-you-go-subscription-on-aws-marketplace.md
- hidden: deploy/elastic-cloud/azure-marketplace-pricing.md
- hidden: deploy/elastic-cloud/create-monthly-pay-as-you-go-subscription-on-gcp-marketplace.md

@florent-leborgne
Copy link
Contributor

Should I unhide all of these as well ?

No, these ones were specifically requested to be hidden (they are also hidden in the asciidoc docs).

For the page added in that PR, I'd let Eric decide

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from latest comments from Eric

@florent-leborgne florent-leborgne enabled auto-merge (squash) April 4, 2025 14:20
@florent-leborgne florent-leborgne merged commit 783d125 into main Apr 4, 2025
4 of 5 checks passed
@florent-leborgne florent-leborgne deleted the PB-3973/add_aws_prepaid_signup_instructions branch April 4, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants