Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define the iterator in the for scope #190

Merged
merged 3 commits into from
May 2, 2024
Merged

Define the iterator in the for scope #190

merged 3 commits into from
May 2, 2024

Conversation

haesbaert
Copy link
Contributor

Otherwise running two FOREACHes in the same scope won't work as it tries to redefine the variable.

@haesbaert
Define the iterator in the for scope
d95292f 
Otherwise running two FOREACHes in the same scope won't work as it tries to
redefine the variable.
@haesbaert haesbaert requested a review from a team as a code owner May 2, 2024 13:03
nicholasberlin
nicholasberlin reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@nicholasberlin nicholasberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the multi-kernel tests pass (which will run automagically.) This feels like a verifier work-around to me, but 🤷

Also, looks like the linting gods require sacrifice.

@haesbaert haesbaert merged commit 62d0aff into main May 2, 2024
24 of 26 checks passed
@haesbaert haesbaert deleted the noscope branch May 2, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasberlin nicholasberlin nicholasberlin approved these changes

@mjwolf mjwolf mjwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haesbaert @mjwolf @nicholasberlin