Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Adding GCS and ABS to allowed inputs in filebeat spec #2149

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Jan 23, 2023

What does this PR do?

Filebeat have two newer inputs that have yet to be added to integration packages. To be able to add these we need to first update the filebeat spec file so they are allowed to run.

Why is it important?

Change is needed to run these new inputs in elastic-agent, and is currently a blocker for us to use them in integration packages.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@P1llus P1llus requested a review from a team as a code owner January 23, 2023 13:48
@P1llus P1llus requested review from AndersonQ and blakerouse and removed request for a team January 23, 2023 13:48
@mergify mergify bot assigned P1llus Jan 23, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 23, 2023

This pull request does not have a backport label. Could you fix it @P1llus? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@P1llus
Copy link
Member Author

P1llus commented Jan 23, 2023

I believe the changelog was only for customer facing changes? Is any other changes required for this to be approved?

This is targeting 8.6.1 and newer.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-23T13:48:25.724+0000

  • Duration: 19 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 4825
Skipped 13
Total 4838

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.305% (58/59) 👍
Files 69.268% (142/205) 👍
Classes 69.231% (270/390) 👍
Methods 54.047% (828/1532) 👍
Lines 39.237% (9003/22945) 👎 -0.022
Conditionals 100.0% (0/0) 💚

@P1llus P1llus added the backport-v8.6.0 Automated backport with mergify label Jan 23, 2023
@mergify mergify bot removed the backport-skip label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.6.0 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants