Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FSM for upgrades #3501

Closed
wants to merge 2 commits into from
Closed

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

This PR adds a finite state machine to model the Elastic Agent upgrade process.

Why is it important?

To help with tracking the various steps in the upgrade process.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • ~I have made corresponding changes to the documentation
  • ~I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool No user-facing changes in this PR.
  • I have added an integration test or an E2E test

Related issues

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 3, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-03T01:50:13.530+0000

  • Duration: 6 min 4 sec

Steps errors 1

Expand to view the steps failures

check
  • Took 1 min 15 sec . View more details here
  • Description: make check-ci

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elastic-sonarqube
Copy link

@ycombinator
Copy link
Contributor Author

It turns out it's not that useful to have an FSM modeling the upgrade states and their transitions for the purposes of upgrade tracking. An FSM may become more useful in the future if we actually use it to execute the various steps in the upgrade process. So, closing this PR unmerged for now.

@ycombinator ycombinator closed this Oct 4, 2023
@ycombinator ycombinator deleted the upgrade-fsm branch October 4, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip enhancement New feature or request skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants