Add integration test to update an agent with another built from the same commit #4256
Conversation
|
This pull request does not have a backport label. Could you fix it @pchila? 🙏
NOTE: |
pchila
force-pushed
the
add-upgrade-collision-test
branch
3 times, most recently
from
4a8b379 to
dce8940
Compare
pchila
added
Team:Elastic-Agent-Control-Plane
pchila
force-pushed
the
add-upgrade-collision-test
branch
from
dce8940 to
55d0041
Compare
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
pchila
changed the title
pchila
force-pushed
the
add-upgrade-collision-test
branch
2 times, most recently
from
f3501cf to
df22004
Compare
pchila
force-pushed
the
add-upgrade-collision-test
branch
2 times, most recently
from
e247713 to
3edb875
Compare
|
|
||
| err = upgradetest.PerformUpgrade(ctx, startFixture, endFixture, t, | ||
| upgradetest.WithUnprivileged(unprivilegedAvailable), | ||
| upgradetest.WithDisableHashCheck(true), |
There was a problem hiding this comment.
Rather than disabling the check, could you invert it? That is require the hash to be the same?
That would enforce that the commit still reads the same after all of the package hacking that goes on as a condition of the test.
There was a problem hiding this comment.
This is to disable the check before starting the upgrade in our integration tests: it's the "fix" we have to in order to avoid hash collisions when upgrading from a snapshot to another snapshot of the same version (it has been introduced by @rdner not too long ago).
This is the check that we are actually disabling https://github.com/elastic/elastic-agent/pull/4256/files#diff-4941bb4aa7d421d6eb86b572bc58968a061897540ef25923d5b2460bfdce10e8R230 that would prevent the test to even begin.
This check would be no longer needed if we switch all the test that use snapshots from the unified build to repackaged agents instead (not sure it's applicable to all the tests we have though).
The commit hash after upgrade is checked anyways using the endFixture which in our case has obviously the same hash
pchila
force-pushed
the
add-upgrade-collision-test
branch
2 times, most recently
from
5b2cb25 to
358f01d
Compare
Support for build id has been introduced to Local Artifact fetcher but it interpretes any build metadata as a buildID. Early release version will use a <major>.<minor>.<patch>+buildYYYYMMDDHHMMSS format and that has to be interpreted as a whole version, not a buildID
pchila
force-pushed
the
add-upgrade-collision-test
branch
from
358f01d to
1a34675
Compare
|
0.0% Duplication on New Code
…ame commit (#4256) * add integration test * Decouple packaging functions from global state * Implement repackaging for tar.gz archives * Implement repackaging for .zip archives * Add a test with a repackaged agent * Change LocalArtifactFetcher to support early release versions * Separate versions for repackaging and integration test fixtures (cherry picked from commit 993b786)
…ame commit (#4256) (#4327) * add integration test * Decouple packaging functions from global state * Implement repackaging for tar.gz archives * Implement repackaging for .zip archives * Add a test with a repackaged agent * Change LocalArtifactFetcher to support early release versions * Separate versions for repackaging and integration test fixtures (cherry picked from commit 993b786) Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
What does this PR do?
This PR will add integration tests checking that:
Why is it important?
The new integration tests prove that #4193 makes it possible to have 2 agent installs from the same hash at the same time on disk (we have this situation when performing an upgrade before the end of the grace period).
It also proves that we can use the same package built from the commit to test certain upgrade flows in CI.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog toolAuthor's Checklist
How to test this PR locally
The new tests can be run using
Related issues
Use cases
Screenshots
Logs
Questions to ask yourself