[8.12](backport #4147) Pass context with timeout to FQDN lookup #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
added
backport
conflicts
mergify
bot
requested review from
AndersonQ and
pchila
and removed request for
a team
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
pierrehilbert
requested review from
ycombinator
and removed request for
AndersonQ and
pchila
|
This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏 |
2 similar comments
|
This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏 |
ycombinator
added
Team:Elastic-Agent
* Pass context with timeout to FQDN lookup * Add temporary gomod replace * Add CHANGELOG fragment * Updating dependency * Update method calls * Extract function * Fallback to OS-provided hostname on FQDN lookup error * Refactoring: reuse * Adding unit tests * Add comment (cherry picked from commit 4c9d865) # Conflicts: # internal/pkg/agent/application/info/agent_metadata.go
ycombinator
force-pushed
the
mergify/bp/8.12/pr-4147
branch
from
dd071fb to
510270b
Compare
|
100.0% Coverage on New Code
0.0% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4147 done by Mergify.
Cherry-pick of 4c9d865 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com