Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unprivileged] Windows enablement #4264
[Unprivileged] Windows enablement #4264
Changes from 43 commits
a74cf31
5b59d62
cd0de99
a72e02a
322c363
5523eff
da71060
685f3d3
6dd742b
f65da0d
4aab797
6ec63f2
94cf61f
c57d4fa
df4e2fb
6aaebc3
b4c3e6d
8c7ed65
733c443
0840e4c
c3943e2
83af91c
909d48a
de92fb7
c619711
7f21ab0
8fec77a
263af6a
5ac6368
0285399
a7ee861
fbf7285
cbefd7e
1916b3a
17ac3d1
2ad71d4
5b6d11c
9312f5c
46fb164
38f5a5f
ade3f50
94bff9a
bb8f2b9
131b24f
60a9835
39bcb29
bb665a7
f9e69d5
ee6a4ab
f989d44
a5ad1e8
d05c552
12f7b16
9e30596
af2cbe7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a comment on why the switch to Token(0) ? We have had so many issues with detecting "admin" I'd just like to be sure we have this documented if things pop up later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
windows.Token(0)
is used because its passed intocheckTokenMembership
that when the token is zero that check uses the current process token. It is a simpler way of saying this processes current token, without the need to grab a handle that needs to be closed for the current process.What do you want documented here? That
windows.Token(0)
means the current process token?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a few links to MSDN documentation, and just a comment that
windows.Token(0)
is current process. I'm just thinking in 3 years if we have a bug around this code in some new Azure environment it is nice to know what we were thinking and hopefully pointers to full documentation which might give clues if it has been deprecated etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some more comments and a link for the
windows.Token(0)
.