Check if non-snapshot version is released before using for testing #4276
Conversation
Currently, we don't check whether a version without the `-SNAPSHOT` suffix is actually released and available on our public CDN. The version is present on the artifact API once the first BC is built, however, this does not mean the version is published on the CDN. This leads to failing upgrade attempts by the agent in our integration tests.
rdner
added
bug
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
| c: new(http.Client), | ||
| url: defaultArtifactAPIURL, | ||
| cdnURL: artifactReleaseCDN, | ||
| c: new(http.Client), |
There was a problem hiding this comment.
not your PR but there's a potential eternal hang
There was a problem hiding this comment.
it's not obvious to me, can you elaborate more?
There was a problem hiding this comment.
Go default http client does not have a timeout
There was a problem hiding this comment.
@AndersonQ this code is used only for testing, would not our test timeout stop the test anyway?
There was a problem hiding this comment.
They will, besides using a context when creating the requests, as you did, will respect the context's cancellation and interrupt the request.
There was a problem hiding this comment.
anyway, for me it isn't a blocker and I'd say it's resolved.
@michalpristas, is it solved for you?
There was a problem hiding this comment.
sorry for late response, this was not a blocker for me
| results = append(results, versionItem) | ||
| continue | ||
| } | ||
| url := fmt.Sprintf("%s/elastic-agent-%s-%s", aac.cdnURL, versionItem, suffix) |
There was a problem hiding this comment.
Will this work the same with the new agent release that will be available out of band thanks to @pchila's work?
There was a problem hiding this comment.
I can't confirm that, not familiar with the spec/implementation details but I'll talk to @pchila and I've assigned him as a reviewer.
There was a problem hiding this comment.
I don't know details yet on how the new elastic-agent-x.y.z+buildYYYYMMDDHHMMSS are gonna be distributed. If Artifact API has those versions correctly returned in the version list and the same exact version appear in the CDN URL this could work otherwise this check will always fail for the early releases
|
0.0% Duplication on New Code
| c: new(http.Client), | ||
| url: defaultArtifactAPIURL, | ||
| cdnURL: artifactReleaseCDN, | ||
| c: new(http.Client), |
There was a problem hiding this comment.
Go default http client does not have a timeout
…4276) Currently, we don't check whether a version without the `-SNAPSHOT` suffix is actually released and available on our public CDN. The version is present on the artifact API once the first BC is built, however, this does not mean the version is published on the CDN. This leads to failing upgrade attempts by the agent in our integration tests. (cherry picked from commit b425e4f)
…4276) Currently, we don't check whether a version without the `-SNAPSHOT` suffix is actually released and available on our public CDN. The version is present on the artifact API once the first BC is built, however, this does not mean the version is published on the CDN. This leads to failing upgrade attempts by the agent in our integration tests. (cherry picked from commit b425e4f)
…4276) (#4281) Currently, we don't check whether a version without the `-SNAPSHOT` suffix is actually released and available on our public CDN. The version is present on the artifact API once the first BC is built, however, this does not mean the version is published on the CDN. This leads to failing upgrade attempts by the agent in our integration tests. (cherry picked from commit b425e4f) Co-authored-by: Denis <denis.rechkunov@elastic.co>
…4276) (#4280) Currently, we don't check whether a version without the `-SNAPSHOT` suffix is actually released and available on our public CDN. The version is present on the artifact API once the first BC is built, however, this does not mean the version is published on the CDN. This leads to failing upgrade attempts by the agent in our integration tests. (cherry picked from commit b425e4f) Co-authored-by: Denis <denis.rechkunov@elastic.co>
What does this PR do?
Currently, we don't check whether a version without the
-SNAPSHOTsuffix is actually released and available on our public CDN.The version is present on the artifact API once the first BC is built, however, this does not mean the version is published on the CDN.
This leads to failing upgrade attempts by the agent in our integration tests.
Why is it important?
Our integration tests are not passing.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry in./changelog/fragmentsusing the changelog tool- [ ] I have added an integration test or an E2E testRelated issues