Skip to content

[8.13](backport #4348) Integration Testing Framework: Add retries for artifacts API call #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 4, 2024

This is an automatic backport of pull request #4348 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner March 4, 2024 23:49
@mergify mergify bot added the backport label Mar 4, 2024
@mergify mergify bot requested review from michalpristas and pchila and removed request for a team March 4, 2024 23:49
@ycombinator ycombinator enabled auto-merge (squash) March 4, 2024 23:58
@pierrehilbert pierrehilbert requested review from ycombinator and removed request for michalpristas and pchila March 5, 2024 10:16
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Mar 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Copy link
Contributor Author

mergify bot commented Mar 5, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.13/pr-4348 upstream/mergify/bp/8.13/pr-4348
git merge upstream/8.13
git push upstream mergify/bp/8.13/pr-4348

)

* Add retries for artifacts API call

* Add newline

* Adding logging

* Pass logger in constructor

* Add missing arg

* Fix logic for happy path

* Adding comment

* Do not keep retrying if request context was cancelled or timed out

(cherry picked from commit 94c7d88)
@ycombinator ycombinator force-pushed the mergify/bp/8.13/pr-4348 branch from 06de5c8 to 53bcd84 Compare March 7, 2024 18:15
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ycombinator ycombinator merged commit 0a873ce into 8.13 Mar 7, 2024
9 checks passed
@ycombinator ycombinator deleted the mergify/bp/8.13/pr-4348 branch March 7, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants