Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main](automation) Update .agent-versions.json #4414

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

This file is used for picking agent versions in integration tests. It's content is based on the reponse from https://artifacts-api.elastic.co/v1/versions/

This file is used for picking agent versions in integration tests. It's content is based on the reponse from https://artifacts-api.elastic.co/v1/versions/
@github-actions github-actions bot requested a review from a team as a code owner March 14, 2024 00:20
@github-actions github-actions bot added Team:Elastic-Agent Label for the Agent team update-versions Updates to the agent versions file labels Mar 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Copy link
Contributor

mergify bot commented Mar 14, 2024

This pull request does not have a backport label. Could you fix it @github-actions[bot]? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

"8.13.0-SNAPSHOT",
"8.12.2",
"8.13.0",
"8.12.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't released yet so shouldn't be appear in this list. The tool is picking up the 8.12.3 staging build, which is essentially equal to 8.12.3-SNAPSHOT since it is produced once per day and isn't a build candidate.

For 8.13.0 it is picking up the build candidate, we should in the future have a specific test pipeline for testing those as they are generated, but for the purposes of testing PRs we are better off with 8.13.0-SNAPSHOT since it moves faster.

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should close this, I think the script is going to keep generating updates we want to ignore until we fix it though.

@cmacknz cmacknz requested a review from rdner March 14, 2024 13:53
@cmacknz cmacknz closed this Mar 14, 2024
@cmacknz cmacknz deleted the update-agent-versions-8273422429 branch March 14, 2024 13:53
@rdner
Copy link
Member

rdner commented Mar 14, 2024

@cmacknz why can't we keep it open until the version is released?
My idea was to keep these PRs until the versions are released and the build passes.

Alternatively, I can put back the logic of checking whether the version is available on our CDN or not (released) and include only released versions.

@rdner
Copy link
Member

rdner commented Mar 14, 2024

Probably we should close this, I think the script is going to keep generating updates we want to ignore until we fix it though.

This would lead to new PRs every day until we merge it. I think we should keep the PR open, so the automation does not create new PRs.

@rdner rdner restored the update-agent-versions-8273422429 branch March 14, 2024 15:02
@rdner rdner reopened this Mar 14, 2024
@rdner
Copy link
Member

rdner commented Mar 14, 2024

Filed an issue for improvements here #4417

@rdner
Copy link
Member

rdner commented Mar 21, 2024

Closing this because #4423 was merged.

@rdner rdner closed this Mar 21, 2024
@rdner rdner deleted the update-agent-versions-8273422429 branch March 21, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip skip-changelog Team:Elastic-Agent Label for the Agent team update-versions Updates to the agent versions file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants