-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main](automation) Update .agent-versions.json #4414
Conversation
This file is used for picking agent versions in integration tests. It's content is based on the reponse from https://artifacts-api.elastic.co/v1/versions/
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This pull request does not have a backport label. Could you fix it @github-actions[bot]? 🙏
NOTE: |
"8.13.0-SNAPSHOT", | ||
"8.12.2", | ||
"8.13.0", | ||
"8.12.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't released yet so shouldn't be appear in this list. The tool is picking up the 8.12.3 staging build, which is essentially equal to 8.12.3-SNAPSHOT since it is produced once per day and isn't a build candidate.
For 8.13.0 it is picking up the build candidate, we should in the future have a specific test pipeline for testing those as they are generated, but for the purposes of testing PRs we are better off with 8.13.0-SNAPSHOT since it moves faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we should close this, I think the script is going to keep generating updates we want to ignore until we fix it though.
@cmacknz why can't we keep it open until the version is released? Alternatively, I can put back the logic of checking whether the version is available on our CDN or not (released) and include only released versions. |
This would lead to new PRs every day until we merge it. I think we should keep the PR open, so the automation does not create new PRs. |
Filed an issue for improvements here #4417 |
Closing this because #4423 was merged. |
This file is used for picking agent versions in integration tests. It's content is based on the reponse from https://artifacts-api.elastic.co/v1/versions/