Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fixture diagnostics unconditionally logging an error. #4448

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Fix fixture diagnostics unconditionally logging an error. #4448

merged 3 commits into from
Mar 21, 2024

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Mar 20, 2024

Observed in #4442 (comment)

We are unconditionally logging an error even when diagnostics were successfully collected on a retry.

@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Mar 20, 2024
@cmacknz cmacknz self-assigned this Mar 20, 2024
@cmacknz cmacknz requested a review from a team as a code owner March 20, 2024 19:12
@cmacknz cmacknz requested review from michalpristas and pchila March 20, 2024 19:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 20, 2024

This pull request does not have a backport label. Could you fix it @cmacknz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@cmacknz cmacknz enabled auto-merge (squash) March 20, 2024 20:28
blakerouse
blakerouse approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@cmacknz cmacknz merged commit bde9684 into elastic:main Mar 21, 2024
9 checks passed
@cmacknz cmacknz deleted the fix-diagnostics-retry-err branch March 21, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@pchila pchila pchila approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@cmacknz cmacknz

Labels
backport-skip skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmacknz @elasticmachine @blakerouse @pchila