Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add metrics-monitoring beats to resource monitoring" #4451

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

rdner
Copy link
Member

@rdner rdner commented Mar 21, 2024

Reverts #4326

These changes caused multiple failures on the CI:

In both builds TestLongRunningAgentForLeaks/TestHandleLeak fails with condition never satisfied (see #4447)

TestMetricsMonitoringCorrectBinaries/TestBeatsMetrics fails with Condition never satisfied.

@rdner rdner self-assigned this Mar 21, 2024
@rdner rdner requested a review from a team as a code owner March 21, 2024 08:36
@rdner rdner requested a review from pchila March 21, 2024 08:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@rdner rdner enabled auto-merge (squash) March 21, 2024 08:43
Copy link

Quality Gate passed Quality Gate passed

The SonarQube Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
52.9% 52.9% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@rdner
Copy link
Member Author

rdner commented Mar 21, 2024

Correction: failing TestLongRunningAgentForLeaks/TestHandleLeak does not seem to be related because it's also failing in this PR.

@pierrehilbert
Copy link
Contributor

As we have a dead lock situation in our PR to fix the CI status, I'm forcing the merge of two of them, the third one should therefore be green and be merged normally.

@pierrehilbert pierrehilbert disabled auto-merge March 21, 2024 12:35
@pierrehilbert pierrehilbert merged commit 7f83ddd into main Mar 21, 2024
11 of 12 checks passed
@pierrehilbert pierrehilbert deleted the revert-4326-add-metrics-beats-to-monitoring branch March 21, 2024 12:35
@cmacknz
Copy link
Member

cmacknz commented Mar 21, 2024

Re opened #4082 since the entire feature was reverted.

fearful-symmetry added a commit to fearful-symmetry/elastic-agent that referenced this pull request Mar 21, 2024
fearful-symmetry added a commit that referenced this pull request Mar 27, 2024
… fleet naming changes (#4462)

* Reapply "Add metrics-monitoring beats to resource monitoring (#4326)" (#4451)

This reverts commit 7f83ddd.

* revert removal, make it easier to adjust unit ID output name

* update unit names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants