Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disruptive change mitigations section to PR template #4645

Merged
merged 5 commits into from
May 6, 2024

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 30, 2024

This PR adds a new section to the PR template for describing any steps users could take to mitigate disruptive changes, when a PR introduces such changes.

@ycombinator ycombinator added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team skip-changelog chore Tasks that just need to be done, they are neither bug, nor enhancements labels Apr 30, 2024
@ycombinator ycombinator requested a review from a team as a code owner April 30, 2024 22:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@ycombinator ycombinator changed the title Add breaking change mitigations section and checklist item Add breaking change mitigations section to PR template Apr 30, 2024
Copy link
Contributor

mergify bot commented Apr 30, 2024

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@ycombinator ycombinator requested review from a team and kpollich April 30, 2024 22:31
@ycombinator ycombinator changed the title Add breaking change mitigations section to PR template Add disruptive change mitigations section to PR template May 1, 2024
Copy link
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

mergify bot commented May 1, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b pr-template-breaking-changes upstream/pr-template-breaking-changes
git merge upstream/main
git push upstream pr-template-breaking-changes

@ycombinator ycombinator force-pushed the pr-template-breaking-changes branch from 6eb9c47 to 445ef35 Compare May 1, 2024 20:29
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ycombinator ycombinator merged commit 66458cb into elastic:main May 6, 2024
9 checks passed
@ycombinator ycombinator deleted the pr-template-breaking-changes branch May 6, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip chore Tasks that just need to be done, they are neither bug, nor enhancements skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants