-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use go install
instead of go get
#4672
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This pull request does not have a backport label. Could you fix it @belimawr? 🙏
NOTE: |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Calling `go get` was causing `mage check` to fail with: ``` go: modules disabled by GO111MODULE=off; see 'go help modules' Error: running "go get github.com/elastic/go-licenser@latest" failed with exit code 1 ``` This commit fixes it by using `go install` instead.
|
What does this PR do?
Calling
go get
was causingmage check
to fail with:This commit fixes it by using
go install
instead.Why is it important?
It makes
mage check
work againChecklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in./changelog/fragments
using the changelog toolI have added an integration test or an E2E testHow to test this PR locally
Run
mage check
it should succeed## Related issuesQuestions to ask yourself