Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmark input to filebeat spec file #4831

Closed
wants to merge 1 commit into from

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Adds the filebeat benchmark input (added for 8.14) to the filebeat spec file

Why is it important?

Without this integrations can not be written that use the benchmark input.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Write an integration that uses the benchmark input

elastic/integrations#8733

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

Sorry, something went wrong.

@leehinman leehinman requested a review from a team as a code owner May 31, 2024 15:34
Copy link
Contributor

mergify bot commented May 31, 2024

This pull request does not have a backport label. Could you fix it @leehinman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@leehinman leehinman added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label May 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert requested review from belimawr and rdner May 31, 2024 16:11
@@ -57,6 +57,12 @@ inputs:
outputs: *outputs
shippers: *shippers
command: *command
- name: benchmark
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want this to go in https://github.com/elastic/beats/blob/main/x-pack/agentbeat/agentbeat.spec.yml

I started the work to remove these to avoid this confusion but it isn't done yet.

@leehinman
Copy link
Contributor Author

Closing in favor of elastic/beats#39789

@leehinman leehinman closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants